[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log functi
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names |
Date: |
Wed, 13 Feb 2013 21:00:01 +0000 |
On Mon, Feb 11, 2013 at 4:41 PM, Peter Maydell <address@hidden> wrote:
> This patchset is just cleanups; it has two major aims:
> * remove 'cpu' from public-facing qemu_log function/type/etc
> names, since the logging is now entirely generic and not
> tied to TCG CPU debug logging at all
> * remove unnecessary indirection through cpus.c (ie set_cpu_log
> and set_cpu_log_filename) in favour of just having vl.c
> call the appropriate qemu_log functions. [I think this indirection
> was a legacy from before commit 3b823210, when qemu-log.h
> could not be included in files that were in libhw.]
Nice series.
Acked-by: Blue Swirl <address@hidden>
>
> thanks
> -- PMM
>
> Peter Maydell (6):
> qemu-log: Unify {cpu_set,set_cpu}_log_filename as
> qemu_set_log_filename
> qemu-log: Abstract out "print usage message about valid log
> categories"
> qemu-log: Rename cpu_str_to_log_mask to qemu_str_to_log_mask
> qemu-log: Rename the public-facing cpu_set_log function to
> qemu_set_log
> cpus.c: Drop unnecessary set_cpu_log()
> qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem,
> qemu_log_items
>
> bsd-user/main.c | 12 ++++--------
> cpus.c | 21 ---------------------
> hw/ppc.c | 2 +-
> include/qemu/log.h | 27 ++++++++++++++++++---------
> include/sysemu/cpus.h | 2 --
> linux-user/main.c | 14 +++++---------
> monitor.c | 10 +++++-----
> qemu-log.c | 25 +++++++++++++++++--------
> target-i386/translate.c | 2 +-
> tcg/tci/tcg-target.c | 2 +-
> vl.c | 11 +++++++++--
> 11 files changed, 61 insertions(+), 67 deletions(-)
>
> --
> 1.7.9.5
>
- Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories", (continued)
- [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 6/6] qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem, qemu_log_items, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log(), Peter Maydell, 2013/02/11
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Richard Henderson, 2013/02/11
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Stefan Hajnoczi, 2013/02/12
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Blue Swirl, 2013/02/16