[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] target-i386: add stubs for hyperv_(vapic_re
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)() |
Date: |
Tue, 19 Feb 2013 15:38:52 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 11, 2013 at 05:35:04PM +0100, Igor Mammedov wrote:
> It's needed for converting hv_* features into properties and to
> avoid build breakage when qemu is built with --disable-kvm option.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reported-by: Eduardo Habkost <address@hidden>
I hope we avoid the need for the stubs when we implement the
KVM-specific subclasses (that I assume wouldn't be compiled if
--disable-kvm is used). But by now we will need the stubs, so:
Reviewed-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/hyperv.h | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/target-i386/hyperv.h b/target-i386/hyperv.h
> index bacb1d4..7bd4d9e 100644
> --- a/target-i386/hyperv.h
> +++ b/target-i386/hyperv.h
> @@ -30,16 +30,19 @@
> void hyperv_enable_vapic_recommended(bool val);
> void hyperv_enable_relaxed_timing(bool val);
> void hyperv_set_spinlock_retries(int val);
> +bool hyperv_vapic_recommended(void);
> +bool hyperv_relaxed_timing_enabled(void);
> +int hyperv_get_spinlock_retries(void);
> #else
> static inline void hyperv_enable_vapic_recommended(bool val) { }
> static inline void hyperv_enable_relaxed_timing(bool val) { }
> static inline void hyperv_set_spinlock_retries(int val) { }
> +static inline bool hyperv_vapic_recommended(void) { return false; }
> +static inline bool hyperv_relaxed_timing_enabled(void) { return false; }
> +static inline int hyperv_get_spinlock_retries(void) { return 0; }
> #endif
>
> bool hyperv_enabled(void);
> bool hyperv_hypercall_available(void);
> -bool hyperv_vapic_recommended(void);
> -bool hyperv_relaxed_timing_enabled(void);
> -int hyperv_get_spinlock_retries(void);
>
> #endif /* QEMU_HW_HYPERV_H */
> --
> 1.7.1
>
>
--
Eduardo
- Re: [Qemu-devel] [PATCH 1/9] target-i386: cpu: convert existing dynamic properties into static properties, (continued)
[Qemu-devel] [PATCH 5/9] target-i386: convert 'hv_vapic' to static property, Igor Mammedov, 2013/02/11
[Qemu-devel] [PATCH 2/9] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)(), Igor Mammedov, 2013/02/11
- Re: [Qemu-devel] [PATCH 2/9] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)(),
Eduardo Habkost <=
[Qemu-devel] [PATCH 7/9] target-i386: cleanup 'foo' feature handling', Igor Mammedov, 2013/02/11
[Qemu-devel] [PATCH 8/9] target-i386: cleanup 'foo=val' feature handling, Igor Mammedov, 2013/02/11
[Qemu-devel] [PATCH 3/9] target-i386: convert 'hv_spinlocks' to static property, Igor Mammedov, 2013/02/11
[Qemu-devel] [PATCH 6/9] target-i386: convert 'check' and 'enforce' to static properties, Igor Mammedov, 2013/02/11
[Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties, Igor Mammedov, 2013/02/11