[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 1/8] block: add virtual_size to query-block QMP ou
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC 1/8] block: add virtual_size to query-block QMP output |
Date: |
Mon, 11 Mar 2013 11:35:38 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/09/2013 03:22 PM, Stefan Hajnoczi wrote:
> There is currently no way to query the size of a drive. Add a
> 'virtual_size' field to the 'query-block' QMP output.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block.c | 1 +
> qapi-schema.json | 5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 124a9eb..0128e27 100644
> --- a/block.c
> +++ b/block.c
> @@ -2908,6 +2908,7 @@ BlockInfo *bdrv_query_info(BlockDriverState *bs)
> info->has_inserted = true;
> info->inserted = g_malloc0(sizeof(*info->inserted));
> info->inserted->file = g_strdup(bs->filename);
> + info->inserted->virtual_size = bdrv_getlength(bs);
> info->inserted->ro = bs->read_only;
> info->inserted->drv = g_strdup(bs->drv->format_name);
> info->inserted->encrypted = bs->encrypted;
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 28b070f..6b64aec 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -751,6 +751,8 @@
> #
> # @iops_wr: write I/O operations per second is specified
> #
> +# @virtual_size: size of block device, in bytes
It is traditional to list 'since 1.5' when adding a field that did not
appear in earlier qemu releases.
> +#
> # Since: 0.14.0
> #
> # Notes: This interface is only found in @BlockInfo.
> @@ -760,7 +762,8 @@
> '*backing_file': 'str', 'backing_file_depth': 'int',
> 'encrypted': 'bool', 'encryption_key_missing': 'bool',
> 'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int',
> - 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} }
> + 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',
> + 'virtual_size': 'int' } }
I was about to suggest 'virtual-size' instead of 'virtual_size', since
we prefer '-' over '_' in QMP; but since this command has pre-existing
uses of '_', keeping consistency within the struct trumps consistency
with the rest of QMP.
The idea makes sense, and my only complaint was a trivial documentation
matter; so feel free to add this when re-posting without the RFC:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC 0/8] block: Live backup prototype, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 1/8] block: add virtual_size to query-block QMP output, Stefan Hajnoczi, 2013/03/09
- Re: [Qemu-devel] [RFC 1/8] block: add virtual_size to query-block QMP output,
Eric Blake <=
- [Qemu-devel] [RFC 2/8] add basic backup support to block driver, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 4/8] block: add block_backup QMP command, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 5/8] Add nbd server Python module, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 6/8] Add VMA backup archive writer Python module, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 7/8] Add vma-writer.py tool, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 8/8] Add backup.py tool, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc, Stefan Hajnoczi, 2013/03/09