[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 4/8] block: add block_backup QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC 4/8] block: add block_backup QMP command |
Date: |
Thu, 14 Mar 2013 15:46:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/09/2013 03:22 PM, Stefan Hajnoczi wrote:
> @block-backup
>
> Start a point-in-time copy of a block device to a new destination.
>
Is a BLOCK_JOB_COMPLETED event emitted when the copy is completed? If
not, it should be.
> +# Since 1.5
> +##
> +{ 'command': 'block-backup',
> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str',
> + '*mode': 'NewImageMode', '*speed': 'int' } }
This creates a new job type - do you need to update other locations
(such as BlockJobInfo's @type, and in QMP/qmp-events.txt under
BLOCK_JOB_CANCELLED/BLOCK_JOB_COMPLETED @type) to call out what string
is used for the new job type? For that matter, is it finally time to
introduce a new enum type for all valid block job types, and use that
enum type instead of 'str' anywhere QMP data structures distinguish
based on job type?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC 0/8] block: Live backup prototype, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 1/8] block: add virtual_size to query-block QMP output, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 2/8] add basic backup support to block driver, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 4/8] block: add block_backup QMP command, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 5/8] Add nbd server Python module, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 6/8] Add VMA backup archive writer Python module, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 7/8] Add vma-writer.py tool, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 8/8] Add backup.py tool, Stefan Hajnoczi, 2013/03/09
- [Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc, Stefan Hajnoczi, 2013/03/09
- Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype, Dietmar Maurer, 2013/03/10