Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic

[Peter Maydell]

On 15 April 2013 17:14, Paolo Bonzini <address@hidden> wrote:
> Il 15/04/2013 18:09, Peter Maydell ha scritto:
>>> > +if test "$targetos" = Linux && test "$cpu" = i386 -o "$cpu" = x86_64; 
>>> > then
>> test -o is deprecated by POSIX; better to use
>>   if test ... && ( test ... || test ... ); then
>>
>> in new code.
>
> True, on the other hand "(.*test" has no match at all in configure; and
> since we know that $cpu does not begin with a dash, it is portable in
> practice.
>
> I would agree with you, but it looks like convention trumps the
> suggested practice.

I've been consistently saying this in code review for
all new shell code for some time now. You just happen
to have the first example of X && (Y || Z); most
of configure's conditionals are not that complex.

-- PMM