qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/15] block: Enable filename option


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 03/15] block: Enable filename option
Date: Mon, 15 Apr 2013 11:43:10 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 04/12/2013 02:47 PM, Kevin Wolf wrote:
> This allows using the file.filename option instead of the string that
> comes from -drive file=... and is passed around as a separate parameter.
> The goal is to get rid of this parameter and use the options QDict more
> consistently.
> 
> With this option you can access not only the top-level image, but
> specify a filename for the backing file (currently only if no backing
> file exists, but we'll allow overriding it later)
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c | 31 +++++++++++++++++++++++++++----
>  1 file changed, 27 insertions(+), 4 deletions(-)

Quite a few lines added for a net reduction in parameters, but the
results look nice.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]