Re: [Qemu-devel] [PATCH v3 5/6] vmdk: store fields of VmdkMetaData in cpu endian

[Stefan Hajnoczi]

On Wed, Apr 24, 2013 at 08:44:34PM +0800, Fam Zheng wrote:
> @@ -938,7 +938,7 @@ static int get_cluster_offset(BlockDriverState *bs,
>          }
>  
>          if (m_data) {
> -            m_data->offset = tmp;
> +            m_data->offset = *cluster_offset;

tmp can be dropped now:

-tmp = cpu_to_le32(*cluster_offset);
-l2_table[l2_index] = tmp;
+l2_table[l2_index] = cpu_to_le32(*cluster_offset);