[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into q
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi |
Date: |
Thu, 25 Apr 2013 15:34:05 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Apr 24, 2013 at 05:31:58PM +0200, Pavel Hrdina wrote:
> I'm sending patches for all commands in one patch series because the
> savevm command depends on delvm command.
>
> This patch series introduces new design of these commands:
>
> * QMP vm-snapshot-save:
> - { 'command': 'vm-snapshot-save',
> 'data': { 'name': 'str' },
> 'returns': 'SnapshotInfo' }
> - vm-snapshot-save returns an error if there is an existing snapshot with
> the same name
> - you cannot provide an id for a new snapshot
> - all information about created snapshot will be returned
>
> * QMP vm-snapshot-load
> - { 'command': 'vm-snapshot-load',
> 'data': { '*name': 'str', '*id': 'str' },
> 'returns': 'SnapshotInfo' }
> - one of the name or id must be provided
> - if both are provided they will match only the snapshot with the same
> name
> and id
> - returns SnapshotInfo only if the snapshot exists.
>
> * QMP vm-snapshot-delete:
> - { 'command': 'vm-snapshot-delete',
> 'data': { '*name': 'str', '*id': 'str' },
> 'returns': 'SnapshotInfo' }
> - same rules as vm-snapshot-load
If I cannot specify the id when creating the snapshot, then why can I
provide it when loading/deleting?
In other words, is it useful to support the id arguments? If yes,
please include the reason in the API documentation.
- [Qemu-devel] [PATCH v2 12/12] savevm: remove backward compatibility from bdrv_snapshot_find(), (continued)
- [Qemu-devel] [PATCH v2 12/12] savevm: remove backward compatibility from bdrv_snapshot_find(), Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 06/12] block: update error reporting for bdrv_snapshot_list() and related functions, Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 07/12] savevm: update error reporting for qemu_loadvm_state(), Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions, Pavel Hrdina, 2013/04/24
- Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi, Eric Blake, 2013/04/24
- Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi,
Stefan Hajnoczi <=