Re: [Qemu-devel] [PATCH v1 07/14] net: hub use lock to protect ports list

[liu ping fan]

On Tue, May 21, 2013 at 9:57 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, May 07, 2013 at 01:46:55PM +0800, Liu Ping Fan wrote:
>> From: Liu Ping Fan <address@hidden>
>>
>> Hub ports will run on multi-threads, so use lock to protect them.
>>
>> Signed-off-by: Liu Ping Fan <address@hidden>
>> ---
>>  net/hub.c |   25 ++++++++++++++++++++++++-
>>  1 files changed, 24 insertions(+), 1 deletions(-)
>
> Does this rely on net queue re-entrancy detection?  Otherwise we'll
> deadlock when slirp re-enters the net layer, for example for ARP
> requests.
>
Yes, you are right.

> I suggest moving this later in the patch series when the net queue is
> protected already.
>
Ok.

Thanks
Pingfan
> Stefan