[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading |
Date: |
Tue, 14 Jan 2014 11:06:58 +0800 |
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Mon, 01/13 14:15, Richard Henderson wrote:
> On 01/13/2014 08:59 AM, Paolo Bonzini wrote:
> > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
>
> I really really don't like random numbers that make for non-repeatable builds.
> It's a quality-assurance nightmare.
Can you elaborate this, please?
>
> If you want a non-random number unique to the build, try
>
> git log -n1 --format=format:%H
>
> and perhaps a file containing that hash created by scripts/make-release.
What if the source code is not in a git tree, for example a tarball?
Thanks,
Fam
- [Qemu-devel] [PATCH v15 3/9] block: use per-object cflags and libs, (continued)
- [Qemu-devel] [PATCH v15 3/9] block: use per-object cflags and libs, Paolo Bonzini, 2014/01/13
- [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic, Paolo Bonzini, 2014/01/13
- [Qemu-devel] [PATCH v15 5/9] build-sys: introduce common-obj-m and block-obj-m for DSO, Paolo Bonzini, 2014/01/13
- [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Paolo Bonzini, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Peter Maydell, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Peter Maydell, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Richard Henderson, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Richard Henderson, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Paolo Bonzini, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Peter Maydell, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Paolo Bonzini, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Richard Henderson, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Daniel P. Berrange, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Daniel P. Berrange, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Fam Zheng, 2014/01/15
[Qemu-devel] [PATCH v15 7/9] Makefile: install modules with "make install", Paolo Bonzini, 2014/01/13
[Qemu-devel] [PATCH v15 9/9] block: convert block drivers linked with libs to modules, Paolo Bonzini, 2014/01/13