qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-


From: Michal Privoznik
Subject: Re: [Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-set-time command
Date: Thu, 13 Feb 2014 18:33:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 31.01.2014 19:12, Eric Blake wrote:
On 01/31/2014 03:29 AM, Michal Privoznik wrote:
As the description to the guest-set-time states, the command is
there to ease time synchronization after resume. If guest was
suspended for longer period of time, its system time can go off
so badly, that even NTP refuses to set it. That's why the command
was invented: to give users chance to set the time (not
necessarily 100% correct). However, there's is no real need for
us to require users to pass an arbitrary time. Especially if we
can read the correct value from RTC (boiling down to reading
host's time). Hence this commit enables logic:

guest-set-time() == guest-set-time($now_from_rtc)

Signed-off-by: Michal Privoznik <address@hidden>
---
diff to v1:
-Fix checkpatch.pl warnings

  qga/commands-posix.c | 41 +++++++++++++++++++++++++----------------
  qga/commands-win32.c | 34 +++++++++++++++++++++++-----------
  qga/qapi-schema.json |  9 +++++----
  3 files changed, 53 insertions(+), 31 deletions(-)

Reviewed-by: Eric Blake <address@hidden>


May I kindly ask somebody to merge this? Or is 3ACKs required for the guest agent too? Thanks in advance!

Michal



reply via email to

[Prev in Thread] Current Thread [Next in Thread]