[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts |
Date: |
Thu, 13 Feb 2014 10:45:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/13/2014 09:13 AM, Igor Mammedov wrote:
> Adds option to -m
> "mem" - startup memory amount
>
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in MiB.
>
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> v3:
> - fixes suggested by Eric Blake <address@hidden>
> - check for empty string in more efficient way
> - fix MB/MiB inconsistency
> - use EXIT_FAILURE instead of 1
> - add missing exit() if overflow occurres
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature