Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

[Igor Mammedov]

On Mon, 17 Feb 2014 09:29:20 +0100
Gerd Hoffmann <address@hidden> wrote:

> On Fr, 2014-02-07 at 13:51 +0100, Igor Mammedov wrote:
> > Since introduction of PCIHP, it became problematic to
> > punch hole in PCI0._CRS statically since PCI hotplug
> > region size became runtime changeable.
> > 
> > So replace static hole punching with dynamically consumed
> > resources in a child device on PCI0 bus. i.e generate
> > PNP0C02 device as a child of PCI0 bus at runtime and
> > consume GPE0, PCI/CPU hotplug IO resources in it instead
> > of punching holes in static PCI0._CRS.
> 
> Nice.  Can you try to do that for the mmconf xbar in memory space too
> while being at it?
If I manage to convince mst in using macro approach.

PS:
Although his build_append_foo() functions have tremendously improved
dynamic AML generation (made it much less error-prone), the
current acpi-build.c becomes harder to read (just look at new pcihp
parts). So I'm arguing in favor of more simple/intuitive API
approach even if it uses macros (I'm really not fun of it,
but result is much clear/maintainable code).

> 
> cheers,
>   Gerd
> 
>