[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] qemu-img amend: Support multiple -o opti
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] qemu-img amend: Support multiple -o options |
Date: |
Thu, 20 Feb 2014 09:18:34 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/20/2014 07:57 AM, Kevin Wolf wrote:
> Instead of ignoring all option values but the last one, multiple -o
> options now have the same meaning as having a single option with all
> settings in the order of their respective -o options.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qemu-img.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Same comment as in 2/6 about the surprise of a trailing comma empty
option turning into a literal comma.
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/qemu-img.c b/qemu-img.c
> index ba6e82d..d6dc7ec 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -2658,7 +2658,13 @@ static int img_amend(int argc, char **argv)
> help();
> break;
Noticed this in context - this break is dead code, since help() never
returns. (And remind me again WHY help has to return with non-zero
status, even when explicitly requested?)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 1/6] qemu-option: Introduce has_help_option(), (continued)
- [Qemu-devel] [PATCH v2 2/6] qemu-img create: Support multiple -o options, Kevin Wolf, 2014/02/20
- [Qemu-devel] [PATCH v2 3/6] qemu-img convert: Support multiple -o options, Kevin Wolf, 2014/02/20
- [Qemu-devel] [PATCH v2 4/6] qemu-img amend: Support multiple -o options, Kevin Wolf, 2014/02/20
- [Qemu-devel] [PATCH v2 6/6] qemu-iotests: Check qemu-img command line parsing, Kevin Wolf, 2014/02/20
- [Qemu-devel] [PATCH v2 5/6] qemu-img: Allow -o help with incomplete argument list, Kevin Wolf, 2014/02/20