[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive) |
Date: |
Mon, 21 Apr 2014 18:31:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Peter Maydell <address@hidden> wrote:
> On 21 April 2014 15:39, Juan Quintela <address@hidden> wrote:
>> - version_mimium_id_old patches splitted as for Peter requests in:
>> * usb
>> * x86
>> * arm
>> * ppc
>> * rest
>>
>> I splitted basically on that order, so, if a device appears on more
>> than one architecture, 1st one on the list wins
>
> Thanks. How about you get those patches reviewed and in first,
> rather than including them in a 124 patch series which touches
> 238 files? I just don't think this is reviewable at all, even at a
> very high level (I can't tell from diffstat if you're touching all
> these files just for the removal of the version-minimum-id-old
> field or for some other thing too, for instance.) I think you need
> to divide this up into different series and send them through
> the review-and-commit pipeline separately.
The others touch that very same files.
Patches are easy to review in sequence, any of them is very simple, and
the few ones that are long (minimum_version_id_old) review is just
looking that the previous line is minimum_version_id = <same number>.
IMHO, this is the kind of patches that should be introduced at the very
beggining of a release for that very reason. There is no other way that
I can think of changing things all over the tree.
Later, Juan.
- [Qemu-devel] [PATCH 118/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_UINT32, (continued)
- [Qemu-devel] [PATCH 118/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_UINT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 119/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_INT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 120/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_POINTER_UINT16, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 121/124] vmstate: Test for VMSTATE_STRUCT_ARRAY_POINTER_UINT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 122/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_POINTER_INT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 123/124] vmstate: Test for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 124/124] vmstate: Test for VMSTATE_ARRAY_OF_POINTER, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 114/124] vmstate: Remove unused VMSTATE_STRUCT_POINTER_TEST, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 110/124] vmstate: Test for VMSTATE_VARRAY_INT32, Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Peter Maydell, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive),
Juan Quintela <=
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Peter Maydell, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Peter Maydell, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Paolo Bonzini, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Dr. David Alan Gilbert, 2014/04/22
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Paolo Bonzini, 2014/04/27
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Michael S. Tsirkin, 2014/04/27
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
[Qemu-devel] [PATCH 115/124] vmstate: Test for VMSTATE_STRUCT_POINTER, Juan Quintela, 2014/04/21
[Qemu-devel] [PATCH 071/124] vmstate: Remove version field from VMSTATE_STRUCT_VARRAY_UINT32, Juan Quintela, 2014/04/21