[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incom
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incompatible features |
|
Date: |
Thu, 17 Jul 2014 07:16:03 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/17/2014 03:41 AM, Kevin Wolf wrote:
> qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation
> would prevent feature table entries for bits 32-63 from being used, and
> it could assign errp multiple times if there was more than one unknown
> feature, resulting in an error_set() assertion failure.
>
> Fix the truncation, make sure to set the error exactly once and add a
> qemu-iotests case for it.
>
> This fixes https://bugs.launchpad.net/qemu/+bug/1342704/
>
> Reported-by: Maria Kustova <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 21 +++++++++++++-----
> tests/qemu-iotests/036 | 52
> ++++++++++++++++++++++++++++++++++++++++++++-
> tests/qemu-iotests/036.out | 35 ++++++++++++++++++++++++++++++
> tests/qemu-iotests/qcow2.py | 15 ++++++++-----
> 4 files changed, 112 insertions(+), 11 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature