[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incom
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incompatible features |
|
Date: |
Thu, 17 Jul 2014 19:27:03 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jul 17, 2014 at 11:41:53AM +0200, Kevin Wolf wrote:
> qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation
> would prevent feature table entries for bits 32-63 from being used, and
> it could assign errp multiple times if there was more than one unknown
> feature, resulting in an error_set() assertion failure.
>
> Fix the truncation, make sure to set the error exactly once and add a
> qemu-iotests case for it.
>
> This fixes https://bugs.launchpad.net/qemu/+bug/1342704/
>
> Reported-by: Maria Kustova <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 21 +++++++++++++-----
> tests/qemu-iotests/036 | 52
> ++++++++++++++++++++++++++++++++++++++++++++-
> tests/qemu-iotests/036.out | 35 ++++++++++++++++++++++++++++++
> tests/qemu-iotests/qcow2.py | 15 ++++++++-----
> 4 files changed, 112 insertions(+), 11 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpeQa4wzZVHU.pgp
Description: PGP signature