Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests.

[Eric Blake]

On 08/29/2014 09:28 AM, Richard W.M. Jones wrote:
> On Fri, Aug 29, 2014 at 09:10:10AM -0600, Eric Blake wrote:
>> On 08/29/2014 09:03 AM, Richard W.M. Jones wrote:
>>> In order to access VMware ESX efficiently, we need to send a session
>>> cookie.  This patch is very simple and just allows you to send that
>>> session cookie.  It punts on the question of how you get the session
>>> cookie in the first place, but in practice you can just run a `curl'
>>> command against the server and extract the cookie that way.
>>>

>>
>> We still don't have a QMP mapping for curl device hotplug.  But when we
>> gain one, do we really want to have a single (long) string containing
>> multiple cookies, or would it be better to make this an array argument?
>>  On the command-line, which is nicer, taking the cookie option multiple
>> times ('file.cookie=xyz,file.cookie.abc'), taking it as an automatic
>> array ('file.cookie.0=xyz,file.cookie.1=abc') or forcing the user to
>> cram all cookies into a single option ('file.cookie="xyz;abc"')?
> 
> For my immediate needs, I don't care at all about multiple cookies.
> It's just a side-effect of the CURL API that they would work here.
> I'm happy to drop all references to them from the documentation ...

Okay, given that we are treating the string as an opaque passthrough to
keep curl happy, and not something we are processing internally, I'm
happy with keeping it as a single (long) string, and just simplifying
the docs to mention that it is a string for curl to use, perhaps without
needing to go into details on whether it allows one vs. multiple cookies.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature