qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/7] parallels format support improvements


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH v3 0/7] parallels format support improvements
Date: Tue, 2 Dec 2014 13:33:40 +0300
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 06/11/14 15:54, Denis V. Lunev wrote:
The patchset implements additional compatibility bits for Parallels
format:
- initial support of parsing of Parallels DiskDeskriptor.xml
   Typically Parallels disk bundle consists of several images which are
   glued by XML disk descriptor. Also XML hides inside several important
   parameters which are not available in the image header.
- support for padded Parallels images.
   For the time being Parallels was created an optimization for such OSes
   in its desktop product. Desktop users are not qualified enough to create
   properly aligned installations. Thus Parallels makes a blind guess
   on a customer behalf and creates so-called "padded" images if guest
   OS type is specified as WinXP, Win2k and Win2k3.

The code uses approach from VMDK support, either image or XML descriptor
could be used. Though there is temporary hack in the opening code:
BlockDriverState->file is being reopened inside parallels_open. I prefer
to keep this code in this state till proper Parallels snapshots support
in order to minimize current changes.

Changes from v2:
- (patch 1) changed libxml2 addition as suggested by Michael Tokarev
- (patch 2) changed API of xml_find/xml_get_text to avoid memcpy to variable
   on stack
- (patch 2) dropped predefined value for PARALLELS_XML/PARALLELS_IMAGE
- (patch 2) other minor changes (spelling, placement)
- (patch 3) quoted TEST_IMG as suggested by Jeff Cody
- (patches 4, 6) quoted TEST_IMG as suggested by Jeff Cody

Changes from v1:
- dropped already merged part (original patches 1-3)

CC: Jeff Cody <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Roman Kagan <address@hidden>
CC: Denis V. Lunev <address@hidden>

ping



reply via email to

[Prev in Thread] Current Thread [Next in Thread]