Re: [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers

[Gerd Hoffmann]

  Hi,

> > +    fprintf(stderr, "%s: id \"%s\"\n", __func__, id);
> 
> A debug message, isn't it?

Yes, dropped.

> > +
> > +    vnc_display_init(id);
> > +    vnc_display_open(id, &local_err);
> > +    if (local_err != NULL) {
> > +        error_report("Failed to start VNC server on `%s': %s",
> > +                     qemu_opt_get(opts, "display"),
> > +                     error_get_pretty(local_err));
> > +        error_free(local_err);
> > +        exit(1);
> 
> Now, this function is called by main() and qmp_change_vnc_listen() ,
> That's ok for main() exit if encounter any errors, but don't adapt to qmp
> command IMHO.

Correct.  Fixed qmp up to call vnc_display_open directly.

cheers,
  Gerd