[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/17] ahci: add support for restarting non-q
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/17] ahci: add support for restarting non-queued commands |
Date: |
Wed, 17 Dec 2014 10:41:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 17/12/2014 02:36, John Snow wrote:
> + * If an error was there, ad->busy_slot will not be -1. Restarting
> + * the operation will resume execution of the command list, do
> + * nothing here.
I wrote this comment, and I had to reread it twice to make sense of it.
Perhaps:
* If an error was there, ad->busy_slot will not be -1. In that
* case, restarting the operation will resume execution of the
* command list. Otherwise we have to do it here.
Paolo
- [Qemu-devel] [PATCH v2 05/17] ide: pass IDEBus to the restart_cb, (continued)
- [Qemu-devel] [PATCH v2 05/17] ide: pass IDEBus to the restart_cb, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 07/17] ide: remove restart_cb callback, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 06/17] ide: move restart callback to common code, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 08/17] ide: replace set_unit callback with more IDEBus state, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 09/17] ide: place initial state of the current request to IDEBus, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 11/17] ide: commonize io_buffer_index initialization, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 10/17] ide: migrate initial request state via IDEBus, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 12/17] ide: make more functions static, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 13/17] ide: support PIO restart for the ISA controller, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 15/17] ahci: add support for restarting non-queued commands, John Snow, 2014/12/16
- Re: [Qemu-devel] [PATCH v2 15/17] ahci: add support for restarting non-queued commands,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 14/17] ahci: Migrate IDEStatus, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 17/17] qtest/ide: Test flush / retry for ISA and PCI, John Snow, 2014/12/16
- [Qemu-devel] [PATCH v2 16/17] ahci: Recompute cur_cmd on migrate post load, John Snow, 2014/12/16
- Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI, Markus Armbruster, 2014/12/17