[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in get_phys_addr(
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in get_phys_addr() |
|
Date: |
Tue, 27 Jan 2015 19:59:36 +0000 |
On 27 January 2015 at 19:49, Greg Bellows <address@hidden> wrote:
> On Tue, Jan 27, 2015 at 12:12 PM, Peter Maydell <address@hidden>
> wrote:
>> g_assert_not_reached(), but it didn't seem worth cluttering
>> the switch with a bunch of extra labels just to assert that
>> they weren't reachable.
>>
>
> I see how it could clutter things, but given that the routine is generic we
> probably should just like we do in regime_el().
Not a big deal, so I'll add them, but the routine isn't generic --
it's purely a local utility routine for the benefit of the
get_phys_addr family of functions and not intended to be called
from elsewhere.
-- PMM
[Qemu-devel] [PATCH 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores, Peter Maydell, 2015/01/23
[Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags, Peter Maydell, 2015/01/23