[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn() |
Date: |
Thu, 5 Mar 2015 17:15:01 +0100 |
On Thu, 5 Mar 2015 12:38:46 -0300
Eduardo Habkost <address@hidden> wrote:
> One small step in the simplification of cpu_exec_init().
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> exec.c | 2 --
> qom/cpu.c | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 3a61e51..8220535 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -542,8 +542,6 @@ void cpu_exec_init(CPUArchState *env)
> cpu_index++;
> }
> cpu->cpu_index = cpu_index;
> - QTAILQ_INIT(&cpu->breakpoints);
> - QTAILQ_INIT(&cpu->watchpoints);
> #ifndef CONFIG_USER_ONLY
> cpu->as = &address_space_memory;
> cpu->thread_id = qemu_get_thread_id();
> diff --git a/qom/cpu.c b/qom/cpu.c
> index 970377e..b69ac41 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -313,6 +313,8 @@ static void cpu_common_initfn(Object *obj)
> CPUClass *cc = CPU_GET_CLASS(obj);
>
> cpu->gdb_num_regs = cpu->gdb_num_g_regs = cc->gdb_num_core_regs;
> + QTAILQ_INIT(&cpu->breakpoints);
> + QTAILQ_INIT(&cpu->watchpoints);
> }
>
> static int64_t cpu_common_get_arch_id(CPUState *cpu)
- [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn(), Eduardo Habkost, 2015/03/05
- Re: [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn(),
Igor Mammedov <=
- [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 5/6] target-i386: Move TCG initialization to realize time, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init(), Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize, Eduardo Habkost, 2015/03/05