[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id ini
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization |
Date: |
Thu, 5 Mar 2015 17:22:46 +0100 |
On Thu, 5 Mar 2015 12:38:47 -0300
Eduardo Habkost <address@hidden> wrote:
> Instead of initializing cpu->as and cpu->thread_id while holding
> cpu_list_lock(), initialize it earlier.
>
> This allows the code handling cpu_index and global CPU list to be
> isolated from the rest.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> exec.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 8220535..2e370d0 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -534,6 +534,11 @@ void cpu_exec_init(CPUArchState *env)
> CPUState *some_cpu;
> int cpu_index;
>
> +#ifndef CONFIG_USER_ONLY
> + cpu->as = &address_space_memory;
> + cpu->thread_id = qemu_get_thread_id();
> +#endif
> +
> #if defined(CONFIG_USER_ONLY)
> cpu_list_lock();
> #endif
> @@ -542,10 +547,6 @@ void cpu_exec_init(CPUArchState *env)
> cpu_index++;
> }
> cpu->cpu_index = cpu_index;
> -#ifndef CONFIG_USER_ONLY
> - cpu->as = &address_space_memory;
> - cpu->thread_id = qemu_get_thread_id();
> -#endif
> QTAILQ_INSERT_TAIL(&cpus, cpu, node);
> #if defined(CONFIG_USER_ONLY)
> cpu_list_unlock();
- [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn(), Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization, Eduardo Habkost, 2015/03/05
- Re: [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization,
Igor Mammedov <=
- [Qemu-devel] [PATCH 5/6] target-i386: Move TCG initialization to realize time, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init(), Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 1/6] cpu: No need to zero-initialize numa_node, Eduardo Habkost, 2015/03/05