[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 14/19] virtio: introduce vector to virtqueues
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH V4 14/19] virtio: introduce vector to virtqueues mapping |
Date: |
Fri, 20 Mar 2015 12:39:06 +0100 |
On Wed, 18 Mar 2015 17:35:04 +0800
Jason Wang <address@hidden> wrote:
> Currently we will try to traverse all virtqueues to find a subset that
> using a specific vector. This is sub optimal when we will support
> hundreds or even thousands of virtqueues. So this patch introduces a
> method which could be used by transport to get all virtqueues that
> using a same vector. This is done through QLISTs and the number of
> QLISTs was queried through a transport specific method. When guest
> setting vectors, the virtqueue will be linked and helpers for traverse
> the list was also introduced.
>
> The first user will be virtio pci which will use this to speed up
> MSI-X masking and unmasking handling.
>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
> hw/virtio/virtio-pci.c | 8 ++++++++
> hw/virtio/virtio.c | 32 ++++++++++++++++++++++++++++++--
> include/hw/virtio/virtio-bus.h | 1 +
> include/hw/virtio/virtio.h | 3 +++
> 4 files changed, 42 insertions(+), 2 deletions(-)
I'm still not too happy introducing this overhead for all devices when
only pci will make use of it.
Could we perhaps make the queue handling dependant on whether the
transport actually provides the query_nvectors callback?
- Re: [Qemu-devel] [PATCH V4 10/19] virtio-ccw: introduce ccw specific queue limit, (continued)
- [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 11/19] virtio-s390: switch to bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 13/19] virtio-pci: switch to use bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 12/19] virtio-mmio: switch to bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 14/19] virtio: introduce vector to virtqueues mapping, Jason Wang, 2015/03/18
- Re: [Qemu-devel] [PATCH V4 14/19] virtio: introduce vector to virtqueues mapping,
Cornelia Huck <=
- [Qemu-devel] [PATCH V4 16/19] virtio-pci: speedup MSI-X masking and unmasking, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 15/19] virtio: introduce virtio_queue_get_index(), Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 17/19] virtio-pci: increase the maximum number of virtqueues to 513, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 18/19] pci: remove hard-coded bar size in msix_init_exclusive_bar(), Jason Wang, 2015/03/18
[Qemu-devel] [PATCH V4 19/19] virtio-pci: introduce auto_msix_bar_size property, Jason Wang, 2015/03/18