|
From: | Stefan Berger |
Subject: | Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine |
Date: | Fri, 20 Mar 2015 07:43:43 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/19/2015 08:56 AM, Ian Campbell wrote:
On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote:@@ -151,6 +152,8 @@ device_hardware_setup(void) esp_scsi_setup(); megasas_setup(); pvscsi_setup(); + if (runningOnXen()) + vtpm4hvm_setup();Is there anything which is actually Xen specific about the driver in tpm.[ch]? Would it be better to just probe for it, perhaps gates by a Kconfig option which enables TPM support.
I also think the probing should be done. That code can also be recycled from what I posted earlier. It's gated by a Kconfig option, so it doesn't fill up the 128k ROM.
Stefan
And following that train of thought I think you could reasonable drop "4hvm" from the name. And possibly even the leading "v", since I suppose seabios shouldn't really care if the tpm is emulated or real so long as it looks like a real tpm. Ian.
[Prev in Thread] | Current Thread | [Next in Thread] |