[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with buf

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write
Date: Tue, 05 May 2015 18:19:57 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 05/05/2015 17:48, John Snow wrote:
> I specifically left things that alter control flow using hex nibbles --
> such as the FIS packets, PRD tables, and all other existing tests. I
> only use the b64 encoding for raw data patterns, which don't really need
> to be debugged. Either they match or they don't: any particular values
> are uninteresting.

To some extent: they may still be interesting for stuff like IDENTIFY.

> Any future test can be switched to/from hex/b64 by just altering
> "mem{read,write}()" to "buf{read,write}()" as desired. I specifically
> opted not to alter *all* qtest IO for this very reason.
> Does that help? :)

Yes.  We could also switch unconditionally to b64, but keep hex in the

> If you're not opposed to the rest of this series, I will send a v2
> including the hex batching optimization.

This series is okay.  I just wanted some clarifications and ideas for
future work.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]