[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals |
Date: |
Mon, 25 May 2015 15:08:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 25/05/2015 08:22, Peter Crosthwaite wrote:
> Hi Andreas, Richard and all,
>
> I'm moving towards the goal of having no core code usages of ENV_GET_CPU.
> This has two advantages:
>
> 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c
> and friends.
> 2: Multi arch is easier if ENV_GET_CPU stays arch specific. It means I
> don't need those patches where I reorder the env within the arch specific
> CPUState. This allows continuing placement of arch specifics before the
> env in the CPU container (which has TCG perf advantages).
>
> There's a couple more after this pack to get the multi-arch thing going,
> but due to point 1, I'm sending this ahead as I think it has standalone value.
>
> Regards,
> Peter
>
> Peter Crosthwaite (4):
> translate-all: Change tb_flush env argument to cpu
> gdbserver: _fork: Change fn to accept cpu instead of env
> cpus: Change tcg_cpu_exec arg to cpu, not env
> cpus: Change exec_init arg to cpu, not env
>
> bsd-user/main.c | 2 +-
> cpus.c | 7 +++----
> exec.c | 7 +++----
> gdbstub.c | 9 +++------
> include/exec/exec-all.h | 4 ++--
> include/exec/gdbstub.h | 2 +-
> linux-user/main.c | 2 +-
> linux-user/signal.c | 2 +-
> target-alpha/cpu.c | 2 +-
> target-alpha/sys_helper.c | 2 +-
> target-arm/cpu.c | 2 +-
> target-cris/cpu.c | 2 +-
> target-i386/cpu.c | 2 +-
> target-i386/translate.c | 2 +-
> target-lm32/cpu.c | 2 +-
> target-m68k/cpu.c | 2 +-
> target-microblaze/cpu.c | 2 +-
> target-mips/cpu.c | 2 +-
> target-moxie/cpu.c | 2 +-
> target-openrisc/cpu.c | 2 +-
> target-ppc/translate_init.c | 2 +-
> target-s390x/cpu.c | 2 +-
> target-sh4/cpu.c | 2 +-
> target-sparc/cpu.c | 2 +-
> target-tricore/cpu.c | 2 +-
> target-unicore32/cpu.c | 2 +-
> target-xtensa/cpu.c | 2 +-
> translate-all.c | 6 ++----
> 28 files changed, 36 insertions(+), 43 deletions(-)
>
Thanks, queued for 2.4.
Paolo
- [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 1/4] translate-all: Change tb_flush env argument to cpu, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 2/4] gdbserver: _fork: Change fn to accept cpu instead of env, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env, Peter Crosthwaite, 2015/05/25
- [Qemu-devel] [PATCH 4/4] cpus: Change exec_init arg to cpu, not env, Peter Crosthwaite, 2015/05/25
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Andreas Färber, 2015/05/26
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Paolo Bonzini, 2015/05/26
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Andreas Färber, 2015/05/26
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Paolo Bonzini, 2015/05/26
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Andreas Färber, 2015/05/26
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Alexander Graf, 2015/05/26
- Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals, Paolo Bonzini, 2015/05/26