Re: [Qemu-devel] [PATCH 03/29] display: enable DIRTY_MEMORY_VGA tracking explicitly

[Paolo Bonzini]

On 26/05/2015 13:52, Peter Maydell wrote:
> On 26 May 2015 at 12:24, Paolo Bonzini <address@hidden> wrote:
>> > Peter, Mark, Aurelien, can you review and ack this patch?
> Could you provide some explanation/documentation of when a
> display device needs to set DIRTY_MEMORY_VGA (and when it
> doesn't)?

It needs to set it if it uses memory_region_get/set/clear_dirty with
DIRTY_MEMORY_VGA as the last argument.

> If we get it wrong is there any way to make qemu
> assert or otherwise catch the error?

It may be possible to check against mr->dirty_log_mask in
memory_region_get/set/clear_dirty.  However, it is just as likely to
have some corner case that is correct but triggers the assertion.

I haven't thought much about it, because a simple grep for
DIRTY_MEMORY_VGA will catch the device models that need care.

Paolo