[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500 |
Date: |
Thu, 2 Jul 2015 15:25:16 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jul 02, 2015 at 05:14:02PM +0300, Pavel Fedin wrote:
> Instead of adding gic-version option, it is much easier to create a new
> machine
> type. The problem is mc->max_cpus. I tried to change this value inside
> property
> handling code, but it simply did not work, and i still got " Maximum CPUs
> greater than specified machine type limit" error from qemu. It looks like CPU
> number limitation is evaluated before machine is instantiated and properties
> are evaluated. It is possible to make a workaround, of course, but it seems to
> require much more changes than simply subclassing a machine.
>
> This patch also introduces kernel_irqchip_type member in Machine class.
> Currently it it used only by virt machine for its internal purposes, however
> in
> future it is to be passed to KVM in kvm_irqchip_create(). The variable is
> defined as int in order to be architecture agnostic, for potential future
> users.
>
> Signed-off-by: Pavel Fedin <address@hidden>
As mentioned in previous postings, this should be done as a property on
the existing machine type, not a new machine type.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v4 0/9] GIC-500 implementation, software + KVM, Pavel Fedin, 2015/07/02
- [Qemu-devel] [PATCH v4 6/9] Set kernel_irqchip_type for the rest of ARM boards which use GIC, Pavel Fedin, 2015/07/02
- [Qemu-devel] [PATCH v4 9/9] Enable KVM acceleration for GICv3, Pavel Fedin, 2015/07/02
- [Qemu-devel] [PATCH v4 5/9] Extract some reusable vGIC code, Pavel Fedin, 2015/07/02
- [Qemu-devel] [PATCH v4 8/9] Initial implementation of vGICv3, Pavel Fedin, 2015/07/02
- [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/07/02
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500,
Daniel P. Berrange <=
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/07/02
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Christoffer Dall, 2015/07/02
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/07/02
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Christoffer Dall, 2015/07/02
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/07/03
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Christoffer Dall, 2015/07/03
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/07/03
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Christoffer Dall, 2015/07/03
- Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500, Daniel P. Berrange, 2015/07/02
[Qemu-devel] [PATCH v4 3/9] GICv3 support, Pavel Fedin, 2015/07/02