[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/11] vl.c: log system invocation when enabl
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/11] vl.c: log system invocation when enabled |
Date: |
Tue, 04 Aug 2015 16:12:43 +0100 |
Peter Maydell <address@hidden> writes:
> On 4 August 2015 at 13:46, Aurelien Jarno <address@hidden> wrote:
>> On 2015-08-04 13:40, Peter Maydell wrote:
>>> On 3 August 2015 at 10:14, Alex Bennée <address@hidden> wrote:
>>> > gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
>>> > -gcc_flags="-Wformat-security -Wformat-y2k -Winit-self
>>> > -Wignored-qualifiers $gcc_flags"
>>> > +gcc_flags="-Wformat-security -Wno-format-y2k -Winit-self
>>> > -Wignored-qualifiers $gcc_flags"
>>>
>>> Why do we need this warning switch change?
>>
>> Some locales might have the year on 2 digits only, so this triggers a
>> warning. That's also a reason I suggested to use a fixed date format.
>
> Agreed -- we don't want locale-specific log formats.
Is is worth pulling out the standard log date fmt into a #define somewhere?
>
> thanks
> -- PMM
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v4 05/11] qemu-log: Improve the "exec" TB execution logging, (continued)
[Qemu-devel] [PATCH v4 09/11] target-arm: dfilter support for in_asm, op, opt_op, Alex Bennée, 2015/08/03