[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' ty
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type |
Date: |
Tue, 15 Sep 2015 12:39:22 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 14, 2015 at 07:57:52PM +0200, Markus Armbruster wrote:
> It's first class, because unlike '**', it actually works, i.e. doesn't
> require 'gen': false.
>
> '**' will go away next.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> docs/qapi-code-gen.txt | 1 +
> include/qapi/visitor-impl.h | 2 +
> include/qapi/visitor.h | 1 +
> qapi/qapi-dealloc-visitor.c | 9 ++++
> qapi/qapi-visit-core.c | 6 +++
> qapi/qmp-input-visitor.c | 11 +++++
> qapi/qmp-output-visitor.c | 9 ++++
> scripts/qapi-types.py | 1 +
> scripts/qapi.py | 9 ++--
> tests/Makefile | 3 +-
> tests/qapi-schema/args-any.err | 1 +
> .../{flat-union-base-star.exit => args-any.exit} | 0
> tests/qapi-schema/args-any.json | 2 +
> .../{flat-union-base-star.out => args-any.out} | 0
> tests/qapi-schema/flat-union-base-any.err | 1 +
> tests/qapi-schema/flat-union-base-any.exit | 1 +
> ...ion-base-star.json => flat-union-base-any.json} | 2 +-
> tests/qapi-schema/flat-union-base-any.out | 0
> tests/qapi-schema/flat-union-base-star.err | 1 -
> tests/qapi-schema/qapi-schema-test.json | 5 +-
> tests/qapi-schema/qapi-schema-test.out | 9 +++-
> tests/qapi-schema/type-bypass.out | 4 +-
> tests/test-qmp-commands.c | 5 ++
> tests/test-qmp-input-visitor.c | 45 ++++++++++++++++++
> tests/test-qmp-output-visitor.c | 53
> ++++++++++++++++++++++
> 25 files changed, 171 insertions(+), 10 deletions(-)
> create mode 100644 tests/qapi-schema/args-any.err
> rename tests/qapi-schema/{flat-union-base-star.exit => args-any.exit} (100%)
> create mode 100644 tests/qapi-schema/args-any.json
> rename tests/qapi-schema/{flat-union-base-star.out => args-any.out} (100%)
> create mode 100644 tests/qapi-schema/flat-union-base-any.err
> create mode 100644 tests/qapi-schema/flat-union-base-any.exit
> rename tests/qapi-schema/{flat-union-base-star.json =>
> flat-union-base-any.json} (95%)
> create mode 100644 tests/qapi-schema/flat-union-base-any.out
> delete mode 100644 tests/qapi-schema/flat-union-base-star.err
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v7 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions, (continued)
- [Qemu-devel] [PATCH v7 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 24/26] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 15/26] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 26/26] qapi-introspect: Hide type names, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO(), Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 25/26] qapi: New QMP command query-qmp-schema for QMP introspection, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v7 00/26] qapi: QMP introspection, Markus Armbruster, 2015/09/15