Re: [Qemu-devel] [PATCH 4/5] migration: size_t'ify some of qemu-file

[Amit Shah]

On (Thu) 13 Aug 2015 [11:51:33], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> This is a start on using size_t more in qemu-file and friends;
> it fixes up QEMUFilePutBufferFunc and QEMUFileGetBufferFunc
> to take size_t lengths and return ssize_t return values (like read(2))
> and fixes up all the different implementations of them.
> 
> Note that I've not yet followed this deeply into bdrv_ implementations.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Amit Shah <address@hidden>

This is really nice, thanks!

(Though it got me into thinking what values are fine to be stored in
size_t and ssize_t: and the POSIX spec doesn't specify what the
SSIZE_MIN value is; it only says ssize_t can hold -1..SIZE_MAX.  Hope
we don't have fun due to the -errno return values.)

                Amit