[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exe
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec() |
Date: |
Tue, 10 May 2016 22:13:12 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 |
On 10/05/16 19:13, Richard Henderson wrote:
> On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
>> +#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
>> + X86CPU *x86_cpu = X86_CPU(cpu);
>> +
>> + if ((cpu->interrupt_request & CPU_INTERRUPT_POLL)
>> + && replay_interrupt()) {
>> + apic_poll_irq(x86_cpu->apic_state);
>
> Since you're moving this around, you might as well place the x86_cpu
> variable in the inner-most if, next to its only use.
Agree, will fix in v2.
>
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
Kind regards,
Sergey
- [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 2/5] cpu-exec: Move exception handling out of cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 4/5] cpu-exec: Move TB execution stuff out of cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 5/5] cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 3/5] cpu-exec: Move interrupt handling out of cpu_exec(), Sergey Fedorov, 2016/05/10