[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 3/9] target-avr: adding a sample AVR board
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v12 3/9] target-avr: adding a sample AVR board |
Date: |
Mon, 25 Jul 2016 22:10:12 +0100 |
On 25 July 2016 at 21:56, Michael Rolnik <address@hidden> wrote:
> do you mean that I should remove the board and/or device? I use them for
> testing.
You should remove the device, because it's not doing anything.
If that makes the CPU emulation stop working that's a problem
with the CPU emulation that needs to be fixed.
> char const* and const char* are the same.
Yes, this is a style issue. We have over 6000 uses of
'const char' in the codebase and just 16 uses of
'char const' that we've accidentally let slip in over
the years. 'const char *' is the usual way to write it,
so use that.
thanks
-- PMM
- [Qemu-devel] [PATCH v12 0/9] 8bit AVR cores, Michael Rolnik, 2016/07/23
- [Qemu-devel] [PATCH v12 1/9] target-avr: AVR cores support is added., Michael Rolnik, 2016/07/23
- [Qemu-devel] [PATCH v12 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions, Michael Rolnik, 2016/07/23
- [Qemu-devel] [PATCH v12 4/9] target-avr: adding instructions encodings, Michael Rolnik, 2016/07/23
- [Qemu-devel] [PATCH v12 9/9] target-avr: adding instruction decoder, Michael Rolnik, 2016/07/23
- [Qemu-devel] [PATCH v12 8/9] target-avr: instruction decoder generator, Michael Rolnik, 2016/07/23
- [Qemu-devel] [PATCH v12 7/9] target-avr: adding instruction translation, Michael Rolnik, 2016/07/23