[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu |
Date: |
Mon, 10 Oct 2016 18:39:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/10/2016 17:46, Alex Bennée wrote:
> The changes to run_on_cpu and friends mean that all helpers are passed
> the CPUState of vCPU they are running on. The conversion missed the
> field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 which
> introduced bugs.
>
> Reported-by: Claudio Imbrenda <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> kvm-all.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index efb5fe3..3dcce16 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -2215,15 +2215,14 @@ int kvm_sw_breakpoints_active(CPUState *cpu)
>
> struct kvm_set_guest_debug_data {
> struct kvm_guest_debug dbg;
> - CPUState *cpu;
> int err;
> };
>
> -static void kvm_invoke_set_guest_debug(CPUState *unused_cpu, void *data)
> +static void kvm_invoke_set_guest_debug(CPUState *cpu, void *data)
> {
> struct kvm_set_guest_debug_data *dbg_data = data;
>
> - dbg_data->err = kvm_vcpu_ioctl(dbg_data->cpu, KVM_SET_GUEST_DEBUG,
> + dbg_data->err = kvm_vcpu_ioctl(cpu, KVM_SET_GUEST_DEBUG,
> &dbg_data->dbg);
> }
>
>
Queued, thanks - or if Christian wants to send a pull request himself,
he can go ahead.
Paolo
[Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, Claudio Imbrenda, 2016/10/10
- Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, Paolo Bonzini, 2016/10/11
- Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, David Hildenbrand, 2016/10/12
- Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, Claudio Imbrenda, 2016/10/12
- Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, Paolo Bonzini, 2016/10/12
- Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, David Hildenbrand, 2016/10/12
- Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, Paolo Bonzini, 2016/10/13