[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified wrappe
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified wrapper for crypto operation |
Date: |
Mon, 17 Oct 2016 06:32:20 +0000 |
> -----Original Message-----
> From: Stefan Hajnoczi [mailto:address@hidden
> Sent: Sunday, October 16, 2016 9:26 PM
> Subject: Re: [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified
> wrapper for crypto operation
>
> On Thu, Oct 13, 2016 at 03:12:04PM +0800, Gonglei wrote:
> > We use an opaque point to the VirtIOCryptoReq which
> > can support different packets based on different
> > algorithms.
> >
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> > backends/cryptodev-builtin.c | 2 +-
> > backends/cryptodev.c | 28 ++++++++++++++++++++++++++--
> > hw/virtio/virtio-crypto.c | 10 +++++-----
> > include/sysemu/cryptodev.h | 13 +++++++------
> > 4 files changed, 39 insertions(+), 14 deletions(-)
> >
> > diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
> > index 34c45be..dc0a364 100644
> > --- a/backends/cryptodev-builtin.c
> > +++ b/backends/cryptodev-builtin.c
> > @@ -286,7 +286,7 @@ static int cryptodev_builtin_sym_operation(
> > return -VIRTIO_CRYPTO_ERR;
> > }
> > }
> > - return 0;
> > + return VIRTIO_CRYPTO_OK;
> > }
>
> This looks unrelated to the commit description. Please squash the
> VIRTIO_CRYPTO_OK changes into the patches that introduced the old code
> that you are replacing.
OK, I'll rebase it.
Regards,
-Gonglei
- [Qemu-devel] [PATCH v7 00/12] virtio-crypto: introduce framework and device emulation, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 09/12] virtio-crypto: add data queue processing handler, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 11/12] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 01/12] cryptodev: introduce cryptodev backend interface, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 06/12] virtio-crypto-pci: add virtio crypto pci support, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 05/12] virtio-crypto: add virtio crypto device emulation, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified wrapper for crypto operation, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 02/12] cryptodev: add symmetric algorithm operation stuff, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms chainning support, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 04/12] cryptodev: introduce a new cryptodev backend, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 07/12] virtio-crypto: set capacity of algorithms supported, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 03/12] virtio-crypto: introduce virtio_crypto.h, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 08/12] virtio-crypto: add control queue handler, Gonglei, 2016/10/13