[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/32] scsi-block: fix direction of BYTCHK test for V
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 18/32] scsi-block: fix direction of BYTCHK test for VERIFY commands |
Date: |
Mon, 16 Jan 2017 17:59:02 +0100 |
The direction is wrong; scsi_block_is_passthrough returns
false for commands that *can* use sglists.
Reported-by: Zhang Qian <address@hidden>
Fixes: 8fdc7839e40f43a426bc7e858cf1dbfe315a3804
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/scsi-disk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index bdd1e5f..c080888 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2701,7 +2701,7 @@ static bool scsi_block_is_passthrough(SCSIDiskState *s,
uint8_t *buf)
* for the number of logical blocks specified in the length
* field). For other modes, do not use scatter/gather operation.
*/
- if ((buf[1] & 6) != 2) {
+ if ((buf[1] & 6) == 2) {
return false;
}
break;
--
2.9.3
- [Qemu-devel] [PULL 11/32] stubs: group all monitor_fdset_* functions in a single file, (continued)
- [Qemu-devel] [PULL 11/32] stubs: group all monitor_fdset_* functions in a single file, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 12/32] stubs: move vhost stubs to stubs/vhost.o, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 10/32] stubs: group stubs for user-mode emulation, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 09/32] hw: move reset handlers from vl.c to hw/core, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 13/32] event_notifier: cleanups around event_notifier_set_handler, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 14/32] build: remove --enable-colo/--disable-colo, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 15/32] stubs: remove stubs/kvm.c, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 16/32] acpi: filter based on CONFIG_ACPI_X86 rather than TARGET, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 20/32] qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create(), Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 17/32] pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 18/32] scsi-block: fix direction of BYTCHK test for VERIFY commands,
Paolo Bonzini <=
- [Qemu-devel] [PULL 19/32] serial: fix memory leak in serial exit, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 21/32] hxtool: emit Texinfo headings as @subsection, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 24/32] x86: ioapic: fix fail migration when irqchip=split, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 22/32] x86: ioapic: add traces for ioapic, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 23/32] x86: ioapic: dump version for "info ioapic", Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 25/32] exec: Add missing rcu_read_unlock, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 26/32] char: fix ctrl-a b not working, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 27/32] ramblock-notifier: new, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 28/32] kvm: move cpu synchronization code, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 32/32] Revert "win32: don't run subprocess tests on Mingw32 platform", Paolo Bonzini, 2017/01/16