[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 25/32] exec: Add missing rcu_read_unlock
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 25/32] exec: Add missing rcu_read_unlock |
Date: |
Mon, 16 Jan 2017 17:59:09 +0100 |
From: Roman Kapl <address@hidden>
rcu_read_unlock was not called if the address_space_access_valid result is
negative.
This caused (at least) a problem when qemu on PPC/E500+TAP failed to terminate
properly and instead got stuck in a deadlock.
Signed-off-by: Roman Kapl <address@hidden>
Message-Id: <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
---
exec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/exec.c b/exec.c
index 47835c1..c95ae33 100644
--- a/exec.c
+++ b/exec.c
@@ -2960,6 +2960,7 @@ bool address_space_access_valid(AddressSpace *as, hwaddr
addr, int len, bool is_
if (!memory_access_is_direct(mr, is_write)) {
l = memory_access_size(mr, l, addr);
if (!memory_region_access_valid(mr, xlat, l, is_write)) {
+ rcu_read_unlock();
return false;
}
}
--
2.9.3
- [Qemu-devel] [PULL 15/32] stubs: remove stubs/kvm.c, (continued)
- [Qemu-devel] [PULL 15/32] stubs: remove stubs/kvm.c, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 16/32] acpi: filter based on CONFIG_ACPI_X86 rather than TARGET, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 20/32] qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create(), Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 17/32] pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 18/32] scsi-block: fix direction of BYTCHK test for VERIFY commands, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 19/32] serial: fix memory leak in serial exit, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 21/32] hxtool: emit Texinfo headings as @subsection, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 24/32] x86: ioapic: fix fail migration when irqchip=split, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 22/32] x86: ioapic: add traces for ioapic, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 23/32] x86: ioapic: dump version for "info ioapic", Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 25/32] exec: Add missing rcu_read_unlock,
Paolo Bonzini <=
- [Qemu-devel] [PULL 26/32] char: fix ctrl-a b not working, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 27/32] ramblock-notifier: new, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 28/32] kvm: move cpu synchronization code, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 32/32] Revert "win32: don't run subprocess tests on Mingw32 platform", Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 30/32] Plumb the HAXM-based hardware acceleration support, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 31/32] hax: add Darwin support, Paolo Bonzini, 2017/01/16
- [Qemu-devel] [PULL 29/32] target/i386: Add Intel HAX files, Paolo Bonzini, 2017/01/16
- Re: [Qemu-devel] [PULL v2 00/32] Misc patches for 2017-01-11, no-reply, 2017/01/16
- Re: [Qemu-devel] [PULL v2 00/32] Misc patches for 2017-01-11, Peter Maydell, 2017/01/19