[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices |
Date: |
Mon, 23 Jan 2017 11:40:00 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jan 23, 2017 at 10:01:11AM +0800, Jason Wang wrote:
>
>
> On 2017年01月20日 21:08, Peter Xu wrote:
> >This patch is based on Aviv Ben-David (<address@hidden>)'s patch
> >upstream:
> >
> > "IOMMU: enable intel_iommu map and unmap notifiers"
> > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html
> >
> >However I removed/fixed some content, and added my own codes.
> >
> >Instead of translate() every page for iotlb invalidations (which is
> >slower), we walk the pages when needed and notify in a hook function.
> >
> >This patch enables vfio devices for VT-d emulation.
> >
> >Signed-off-by: Peter Xu<address@hidden>
> >---
> > hw/i386/intel_iommu.c | 66
> > +++++++++++++++++++++++++++++++++++++------
> > include/hw/i386/intel_iommu.h | 8 ++++++
> > 2 files changed, 65 insertions(+), 9 deletions(-)
>
> A good side effect of this patch is that it makes vhost device IOTLB works
> without ATS (though may be slow). We probably need a better title :)
How about I mention it in the commit message at the end? Like:
"And, since we already have vhost DMAR support via device-iotlb, a
natural benefit that this patch brings is that vt-d enabled vhost can
live even without ATS capability now. Though more tests are needed."
>
> And I think we should block notifiers during PSI/DSI/GLOBAL for device with
> ATS enabled.
Again, would that be okay I note this in my todo list? :)
Thanks,
-- peterx
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, (continued)
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Peter Xu, 2017/01/22
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Jason Wang, 2017/01/22
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Peter Xu, 2017/01/22
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Jason Wang, 2017/01/23
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Alex Williamson, 2017/01/23
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Peter Xu, 2017/01/23
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Alex Williamson, 2017/01/23
- Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Peter Xu, 2017/01/24
Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices, Jason Wang, 2017/01/22
[Qemu-devel] [PATCH RFC v4 20/20] intel_iommu: replay even with DSI/GLOBAL inv desc, Peter Xu, 2017/01/20
Re: [Qemu-devel] [PATCH RFC v4 00/20] VT-d: vfio enablement and misc enhances, Michael S. Tsirkin, 2017/01/23