Re: [Qemu-devel] [PATCH RFC v4 00/20] VT-d: vfio enablement and misc enhances

[Peter Xu]

On Mon, Jan 23, 2017 at 05:55:51PM +0200, Michael S. Tsirkin wrote:
> On Fri, Jan 20, 2017 at 09:08:36PM +0800, Peter Xu wrote:
> > This is v4 of vt-d vfio enablement series.
> > 
> > Sorry that v4 growed to 20 patches. Some newly added patches (which
> > are quite necessary):
> > 
> > [01/20] vfio: trace map/unmap for notify as well
> > [02/20] vfio: introduce vfio_get_vaddr()
> > [03/20] vfio: allow to notify unmap for very large region
> > 
> >   Patches from RFC series:
> > 
> >   "[PATCH RFC 0/3] vfio: allow to notify unmap for very big region"
> > 
> >   Which is required by patch [19/20].
> > 
> > [11/20] memory: provide IOMMU_NOTIFIER_FOREACH macro
> > 
> >   A helper only.
> > 
> > [19/20] intel_iommu: unmap existing pages before replay
> > 
> >   This solves Alex's concern that there might have existing mappings
> >   in previous domain when replay happens.
> > 
> > [20/20] intel_iommu: replay even with DSI/GLOBAL inv desc
> > 
> >   This solves Jason/Kevin's concern by handling DSI/GLOBAL
> >   invalidations as well.
> > 
> > Each individual patch will have more detailed explanation on itself.
> > Please refer to each of them.
> > 
> > Here I did separate work on patch 19/20 rather than squashing them
> > into patch 18 for easier modification and review. I prefer we have
> > them separately so we can see each problem separately, after all,
> > patch 18 survives in most use cases. Please let me know if we want to
> > squash them in some way. I can respin when necessary.
> > 
> > Besides the big things, lots of tiny tweaks as well. Here's the
> > changelog.
> 
> It would be nice to add to the log
> - known issues / missing features, if any

Sure. Will add them in next post.

> - are there patches ready to be merged here?
>   if yes pls post them without the rfc tag

The series (since V1) should have passed compilation test and simple
functional test (though only with my tiny C program to torture it).
Since I have got lots of review comments, and looks like the whole
thing is acceptable in general, I'll repost with a non-rfc version
with some tweaks upon this one.

Michael, please feel free to pick any of them which you think are
applicable and safe (e.g., the iommu cleanups).

Thanks,

-- peterx