|
From: | Marcel Apfelbaum |
Subject: | Re: [Qemu-devel] [PATCH v5 08/10] PC: Support dynamic sysbus on pc_i440fx |
Date: | Sun, 12 Feb 2017 21:55:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 02/06/2017 06:31 PM, Michael S. Tsirkin wrote:
On Sun, Feb 05, 2017 at 01:12:03AM -0800, address@hidden wrote:From: Ben Warren <address@hidden> This allows pc_i440fx-based machines to add new devices such as VM Generation ID directly to the sysbus. Signed-off-by: Ben Warren <address@hidden>
Hi,
Only point is, we might have to add more flags like cannot_instantiate_with_device_add_yet to a bunch of devices. Marcel, you did a similar thing for q35, can you take a look here as well pls?
The change is a must because the new vmgenid device is a sysbus device and QEMU will not allow it without marking explicitly that i440fx supports sysbus device. As you already mentioned, we need to make sure that all sysbus devices that can be added to the PC machines are marked with "cannot_instantiate_with_device_add_yet". Sadly I see no easy way, but going manually over each one... Thanks, Marcel
--- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 9f102aa..c8ad99c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -435,6 +435,7 @@ static void pc_i440fx_machine_options(MachineClass *m) m->hot_add_cpu = pc_hot_add_cpu; m->default_machine_opts = "firmware=bios-256k.bin"; m->default_display = "std"; + m->has_dynamic_sysbus = true; } static void pc_i440fx_2_9_machine_options(MachineClass *m) -- 2.7.4
[Prev in Thread] | Current Thread | [Next in Thread] |