[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/24] target/openrisc: Use movcond where appropriate
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 14/24] target/openrisc: Use movcond where appropriate |
Date: |
Tue, 14 Feb 2017 08:25:26 +1100 |
Reviewed-by: Bastian Koppelmann <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/openrisc/translate.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
index 6c745d3..f91ab6a 100644
--- a/target/openrisc/translate.c
+++ b/target/openrisc/translate.c
@@ -214,12 +214,16 @@ static void gen_jump(DisasContext *dc, int32_t n26,
uint32_t reg, uint32_t op0)
case 0x03: /* l.bnf */
case 0x04: /* l.bf */
{
- TCGLabel *lab = gen_new_label();
- tcg_gen_movi_tl(jmp_pc, dc->pc+8);
- tcg_gen_brcondi_tl(op0 == 0x03 ? TCG_COND_NE : TCG_COND_EQ,
- cpu_sr_f, 0, lab);
- tcg_gen_movi_tl(jmp_pc, tmp_pc);
- gen_set_label(lab);
+ TCGv t_next = tcg_const_tl(dc->pc + 8);
+ TCGv t_true = tcg_const_tl(tmp_pc);
+ TCGv t_zero = tcg_const_tl(0);
+
+ tcg_gen_movcond_tl(op0 == 0x03 ? TCG_COND_EQ : TCG_COND_NE,
+ jmp_pc, cpu_sr_f, t_zero, t_true, t_next);
+
+ tcg_temp_free(t_next);
+ tcg_temp_free(t_true);
+ tcg_temp_free(t_zero);
}
break;
case 0x11: /* l.jr */
@@ -502,14 +506,10 @@ static void dec_calc(DisasContext *dc, uint32_t insn)
case 0xe: /* l.cmov */
LOG_DIS("l.cmov r%d, r%d, r%d\n", rd, ra, rb);
{
- TCGLabel *lab = gen_new_label();
- TCGv res = tcg_temp_local_new();
- tcg_gen_mov_tl(res, cpu_R[rb]);
- tcg_gen_brcondi_tl(TCG_COND_EQ, cpu_sr_f, 0, lab);
- tcg_gen_mov_tl(res, cpu_R[ra]);
- gen_set_label(lab);
- tcg_gen_mov_tl(cpu_R[rd], res);
- tcg_temp_free(res);
+ TCGv zero = tcg_const_tl(0);
+ tcg_gen_movcond_tl(TCG_COND_NE, cpu_R[rd], cpu_sr_f, zero,
+ cpu_R[ra], cpu_R[rb]);
+ tcg_temp_free(zero);
}
return;
--
2.9.3
- [Qemu-devel] [PULL 03/24] linux-user: Fix openrisc cpu_loop, (continued)
- [Qemu-devel] [PULL 03/24] linux-user: Fix openrisc cpu_loop, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 04/24] linux-user: Honor CLONE_SETTLS for openrisc, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 05/24] target/openrisc: Fix exception handling status registers, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 07/24] target/openrisc: Tidy insn dumping, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 06/24] target/openrisc: Implement lwa, swa, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 08/24] target/openrisc: Rationalize immediate extraction, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 10/24] target/openrisc: Put SR[OVE] in TB flags, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 11/24] target/openrisc: Invert the decoding in dec_calc, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 09/24] target/openrisc: Streamline arithmetic and OVE, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 12/24] target/openrisc: Keep SR_F in a separate variable, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 14/24] target/openrisc: Use movcond where appropriate,
Richard Henderson <=
- [Qemu-devel] [PULL 13/24] target/openrisc: Keep SR_CY and SR_OV in a separate variables, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 16/24] target/openrisc: Enable trap, csync, msync, psync for user mode, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 15/24] target/openrisc: Set flags on helpers, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 17/24] target/openrisc: Implement msync, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 18/24] target/openrisc: Represent MACHI:MACLO as a single unit, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 20/24] target/openrisc: Fix madd, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 19/24] target/openrisc: Implement muld, muldu, macu, msbu, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 21/24] target/openrisc: Optimize l.jal to next, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 22/24] target/openrisc: Tidy ppc/npc implementation, Richard Henderson, 2017/02/13
- [Qemu-devel] [PULL 23/24] target/openrisc: Tidy handling of delayed branches, Richard Henderson, 2017/02/13