[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob A

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob APIs
Date: Mon, 10 Apr 2017 10:30:47 +0100
User-agent: Mutt/1.8.0 (2017-02-23)

On Thu, Mar 23, 2017 at 06:39:23PM +0100, Paolo Bonzini wrote:
> We already have different locking policies for APIs called by the monitor
> and the block job.  Monitor APIs need consistency across block_job_get
> and the actual operation (e.g. block_job_set_speed), so currently there
> are explicit aio_context_acquire/release calls in blockdev.c.
> When a block job needs to do something instead it doesn't care about locking,
> because the whole coroutine runs under the AioContext lock.  When moving
> away from the AioContext lock, the monitor will have to call new
> block_job_lock/unlock APIs, while blockjob APIs will take care of this
> for the users.
> In preparation for that, keep all the blockjob APIs together in the
> blockjob.c file.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  blockjob.c | 206 
> +++++++++++++++++++++++++++++++------------------------------
>  1 file changed, 105 insertions(+), 101 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]