[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 7/9] qemu-img: add measure subcommand

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v4 7/9] qemu-img: add measure subcommand
Date: Tue, 11 Apr 2017 12:33:49 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Wed 05 Apr 2017 05:11:46 PM CEST, Stefan Hajnoczi <address@hidden> wrote:
> +    QemuOptsList *create_opts = NULL;
> +    bool image_opts = false;
> +    uint64_t img_size = ~0ULL;

Any reason to use ~0ULL instead of UINT64_MAX ?

> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -429,6 +429,31 @@ preallocated.
>  For more information, consult @file{include/block/block.h} in QEMU's
>  source code.
> address@hidden measure address@hidden [-O @var{output_fmt}] [-o 
> @var{options}] [--size @var{N} | [--object @var{objectdef}] [--image-opts] 
> [-f @var{fmt}] [-l @var{snapshot_param}] @var{filename}]
> +
> +Calculate the file size required for a new image.  This information can be 
> used
> +to size logical volumes or SAN LUNs appropriately for the image that will be
> +placed in them.  The values reported are guaranteed to be large enough to fit
> +the image.

It's already explained for other commands, but don't you want to mention
what ofmt, output_fmt, etc., mean?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]