[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page di
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page direct jumps in softmmu |
Date: |
Fri, 28 Apr 2017 15:22:38 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Apr 28, 2017 at 15:17:24 -0400, Emilio G. Cota wrote:
> Perf numbers in next commit's log.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/arm/translate-a64.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 24de30d..5b691fc 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -373,8 +373,7 @@ static inline void gen_goto_tb(DisasContext *s, int n,
> uint64_t dest)
> } else if (s->singlestep_enabled) {
> gen_exception_internal(EXCP_DEBUG);
> } else {
> - tcg_gen_exit_tb(0);
> - s->is_jmp = DISAS_TB_JUMP;
I'm not sure about removing this line though. Would it be better to leave it?
I can't see how TB_JUMP ends up doing anything in the rest of the file.
Thanks,
E.
- Re: [Qemu-devel] [PATCH v5 17/19] tcg/aarch64: Implement goto_ptr, (continued)
[Qemu-devel] [PATCH v5++] TCG cross-tb optimizations, Aurelien Jarno, 2017/04/30