[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page di

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page direct jumps in softmmu
Date: Sat, 29 Apr 2017 12:30:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 04/28/2017 09:22 PM, Emilio G. Cota wrote:
On Fri, Apr 28, 2017 at 15:17:24 -0400, Emilio G. Cota wrote:
Perf numbers in next commit's log.

Signed-off-by: Emilio G. Cota <address@hidden>
  target/arm/translate-a64.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 24de30d..5b691fc 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -373,8 +373,7 @@ static inline void gen_goto_tb(DisasContext *s, int n, 
uint64_t dest)
          } else if (s->singlestep_enabled) {
          } else {
-            tcg_gen_exit_tb(0);
-            s->is_jmp = DISAS_TB_JUMP;

I'm not sure about removing this line though. Would it be better to leave it?
I can't see how TB_JUMP ends up doing anything in the rest of the file.

Why not just replace this with

  s->is_jmp = DISAS_JUMP

and not emit the lookup_and_goto_ptr here at all?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]