[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: Remove user_creatable fla
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: Remove user_creatable flag |
Date: |
Wed, 3 May 2017 17:35:50 -0300 |
kvmclock should be used by guests only when the appropriate CPUID
feature flags are set on the VCPU, and it is automatically
created by kvmclock_create() when those feature flags are set.
This means creating a kvmclock device using -device is useless.
Remove user_creatable from its device class.
Cc: Marcel Apfelbaum <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Thomas Huth <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
Changes v1 -> v2:
* (none)
---
hw/i386/kvm/clock.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c
index 7665bef999..13eca374cd 100644
--- a/hw/i386/kvm/clock.c
+++ b/hw/i386/kvm/clock.c
@@ -286,11 +286,6 @@ static void kvmclock_class_init(ObjectClass *klass, void
*data)
dc->realize = kvmclock_realize;
dc->vmsd = &kvmclock_vmsd;
dc->props = kvmclock_properties;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo kvmclock_info = {
--
2.11.0.259.g40922b1
[Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: Remove user_creatable flag,
Eduardo Habkost <=
[Qemu-devel] [PATCH RESEND v2 09/21] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 10/21] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 12/21] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 11/21] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 13/21] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 15/21] esp: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 14/21] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 16/21] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 17/21] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/05/03