|
From: | Juan Quintela |
Subject: | Re: [Qemu-devel] [PATCH 1/2] migration: Fix non-multiple of page size migration |
Date: | Wed, 17 May 2017 21:27:04 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote: > From: "Dr. David Alan Gilbert" <address@hidden> > > Unfortunately it's legal to create a VM with a RAM size that's > not a multiple of the underlying host page or huge page size. > Recently I'd changed things to always send host sized pages, > and that breaks if we have say a 1025MB guest on 2MB hugepages. > > Unfortunately we can't just make that illegal since it would break > migration from/to existing oddly configured VMs. > > Symptom: qemu-system-x86_64: Illegal RAM offset 40100000 > as it transmits the fraction of the hugepage after the end > of the RAMBlock (may also cause a crash on the source > - possibly due to clearing bits after the bitmap) > > Reported-by: Yumei Huang <address@hidden> > Red Hat bug: https://bugzilla.redhat.com/show_bug.cgi?id=1449037 > > Signed-off-by: Dr. David Alan Gilbert <address@hidden> Reviewed-by: Juan Quintela <address@hidden> We should really require for new machine types that ramblocks be multiples of the page size. This is just asking for trouble.
[Prev in Thread] | Current Thread | [Next in Thread] |