[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages |
Date: |
Wed, 17 May 2017 21:29:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> It turns out that it's legal to create a VM with RAMBlocks that aren't
> a multiple of the pagesize in use; e.g. a 1025M main memory using
> 2M host pages. That breaks postcopy's atomic placement of pages,
> so disallow it.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
> }
>
> /* We don't support postcopy with shared RAM yet */
> - if (qemu_ram_foreach_block(test_range_shared, NULL)) {
> + if (qemu_ram_foreach_block(test_ramblock_postcopiable, NULL)) {
When I was looking at this code, I still don't know why
qemu_ram_foreach_block() don't pass the block directly. It needs it
almost all callers.
When I saw it I was about to change it, but got sidetracked on other
things :-p
Later, Juan.